From 49192c194a4eb3c88b261a05fffd5f7aa06c67d2 Mon Sep 17 00:00:00 2001 From: Faizan Qazi Date: Mon, 6 Mar 2023 19:37:05 -0500 Subject: [PATCH] sql/schmachanger: use more friendly language for fallback Previously, the declarative schema changer used slightly alarming language when falling back. To address this, this patch removes the word failure and uses softer langauge. Fixes: #97922 Release note: None --- pkg/sql/schemachanger/scerrors/errors.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/sql/schemachanger/scerrors/errors.go b/pkg/sql/schemachanger/scerrors/errors.go index db4c49a251e8..bec398cefe7b 100644 --- a/pkg/sql/schemachanger/scerrors/errors.go +++ b/pkg/sql/schemachanger/scerrors/errors.go @@ -75,7 +75,7 @@ func (el EventLogger) HandlePanicAndLogError(ctx context.Context, err *error) { log.InfofDepth(ctx, depth, "done %s in %s", el.msg, redact.Safe(timeutil.Since(el.start))) } case HasNotImplemented(*err): - log.InfofDepth(ctx, depth, "failed %s with error: %v", el.msg, *err) + log.InfofDepth(ctx, depth, "unsuccessful in %s with message: %v", el.msg, *err) case errors.HasAssertionFailure(*err): *err = errors.Wrapf(*err, "%s", el.msg) fallthrough