Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify rooting via webusb instead of webserial #163

Closed
stylesuxx opened this issue Sep 27, 2022 · 9 comments
Closed

Unify rooting via webusb instead of webserial #163

stylesuxx opened this issue Sep 27, 2022 · 9 comments
Labels
wontfix This will not be worked on

Comments

@stylesuxx
Copy link
Collaborator

stylesuxx commented Sep 27, 2022

As suggested by @D3VL-Jack the webserial polyfill for webusb could be used instead of webserial. This would allow us to have the user only interact once with the device selection dialog for both rooting and wtfOS related things.

@stylesuxx stylesuxx self-assigned this Sep 27, 2022
@j005u
Copy link
Contributor

j005u commented Sep 27, 2022

This could also allow us to determine rooted state and evolve the UI to hold the users hand more.

@stylesuxx
Copy link
Collaborator Author

stylesuxx commented Sep 27, 2022

Ah yeah, right - now I can remember why I did not use it in the first place - this has actually been an issue with my other configurator too: there are no remove and connect listeners, I submitted a patch which was not merged and the maintainer did not yet implement their intended clean solution.

We could technically use my temporary fix branch...

@stylesuxx
Copy link
Collaborator Author

The web-serial-polyfill does not want to cooperate if web serial itself is available, I simply can't claim the device, even with them demo.html provided in the repo I end up getting an error when attempting to open the device:

serial.ts:311 Uncaught (in promise) Error: Error setting up device: NetworkError: Failed to execute 'claimInterface' on 'USBDevice': Unable to claim interface.
    at SerialPort.open (serial.ts:311:13)
    at async demo.html:64:7

@j005u
Copy link
Contributor

j005u commented Sep 28, 2022

Presumably you made sure nothing else is claiming the iface? Anything in device-logs? Or maybe some udev bullshit?

@stylesuxx
Copy link
Collaborator Author

stylesuxx commented Sep 28, 2022

Yes, I did check that nothing else is claiming the interface. device-logs seem fine, nothing out of the ordinary. I am not the only one having this "issue" though.

You could cross check by running the demo.html from the webserial polyfill repo. As far as I understand the problem is that the system has a driver for the USB Serial device and thus can not be wrapped with the polyfill...

@j005u
Copy link
Contributor

j005u commented Sep 28, 2022

Same, with "Interface 4 uses driver "usbser" instead of WinUSB." in device-log.

So I guess without having the user involve Zadiq, we're boned? Don't want to do that, as then Assistant would break.

@stylesuxx
Copy link
Collaborator Author

Yup, I see it the same way. I don't want to involve external (non cross platform) tools at all.

@D3VL-Jack
Copy link
Contributor

Failed to execute 'claimInterface' on 'USBDevice': Unable to claim interface
Is the exact same error I was seeing when working with the BULK interface, @j005u is absolutely right about winusb driver

@j005u
Copy link
Contributor

j005u commented Sep 28, 2022

r.i.p.

@stylesuxx stylesuxx added the wontfix This will not be worked on label Sep 28, 2022
@stylesuxx stylesuxx removed their assignment Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants