Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static linking support #28

Closed
ajeetdsouza opened this issue Apr 7, 2023 · 6 comments
Closed

Static linking support #28

ajeetdsouza opened this issue Apr 7, 2023 · 6 comments

Comments

@ajeetdsouza
Copy link

Hey, thanks for a fantastic crate! It would be great if you could support static linking - that way, we wouldn't have to rely on the host computer having liblzma installed.

@fpgaminer
Copy link
Owner

Thank you, but I'm sorry to say I'm not maintaining this repo at the moment. There are better lzma Rust crates.

@crazystylus
Copy link
Contributor

Hi @fpgaminer ,
It's not valid to say other crates are better. I have some issues with basic xz extraction on other crates while I am getting no issues when using your crate. Please refer to these issues:

I have added support for static linking to your crate in this fork. Would you accept a PR?

@fpgaminer
Copy link
Owner

It's not valid to say other crates are better.

I mean, they're better because they're maintained... ostensibly, anyway. Odd that your issue on xz2-rs hasn't been touched.

Sure, a PR would be welcome. Please fix the typo(s) if you have a moment.

@ajeetdsouza
Copy link
Author

Odd that your issue on xz2-rs hasn't been touched.

Unfortunately, there are a lot of similar issues on xz2: alexcrichton/xz2-rs#75 (comment)

@fpgaminer
Copy link
Owner

Merged, and I've pushed a new version to crates.io.

@crazystylus
Copy link
Contributor

Merged, and I've pushed a new version to crates.io.

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants