From 77bd9c0cbb96c435ec98f9221fd898835f3050a6 Mon Sep 17 00:00:00 2001 From: Filip Petkovski Date: Tue, 5 Nov 2024 13:36:40 +0100 Subject: [PATCH] Fix bug in Bucket Series Applies the fix described in https://github.com/thanos-io/thanos/issues/7883. Signed-off-by: Filip Petkovski --- pkg/store/bucket.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/store/bucket.go b/pkg/store/bucket.go index 7ab47f4cbe..744823c9fe 100644 --- a/pkg/store/bucket.go +++ b/pkg/store/bucket.go @@ -1691,7 +1691,9 @@ func (s *BucketStore) Series(req *storepb.SeriesRequest, seriesSrv storepb.Store // Merge the sub-results from each selected block. tracing.DoInSpan(ctx, "bucket_store_merge_all", func(ctx context.Context) { begin := time.Now() - set := NewResponseDeduplicator(NewProxyResponseLoserTree(respSets...)) + lt := NewProxyResponseLoserTree(respSets...) + defer lt.Close() + set := NewResponseDeduplicator(lt) i := 0 for set.Next() { i++