Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not recognize 'no proxy for' setting (in Firefox) properly #63

Closed
tmeidinger opened this issue Dec 9, 2023 · 10 comments
Closed

does not recognize 'no proxy for' setting (in Firefox) properly #63

tmeidinger opened this issue Dec 9, 2023 · 10 comments
Labels
area: localhost localhost bypass issues done ✓ duplicate This issue or pull request already exists

Comments

@tmeidinger
Copy link

Browser: Firefox 120.0.1
OS: macOS 14.2

If e.g. 192.168.0.0/24 is set in the Firefox 'no proxy for' setting. FoxyProxy 8.2 is not proxying for 192.168.*.*.

@erosman
Copy link
Collaborator

erosman commented Dec 9, 2023

Do you mean "No proxy for" in Settings -> Network Settings -> Connection Settings?

That setting is only applicable when setting a Remote PAC.

Try setting it in Global Exclude.

@tmeidinger
Copy link
Author

The network on the LAN is 192.168.0.0/24 and version 8.2 doesn't proxy 192.168.178.* any more. Regex rule is ^https?://192.168.178(.\d+) (not working) but e.g. ^https?://10.0.0(.\d+) is working. Even if I am selecting the proxy manually (for all traffic) it's showing in the log 192.168.178.1 is not sent to the proxy.

I downgraded to version 7.5.1 and everything is fine again.

@erosman
Copy link
Collaborator

erosman commented Dec 9, 2023

192.168.0.0/16 is set as global exclude in FoxyProxy in Firefox since it is local network.

Do you want to go to 192.168.0.0/16 via a proxy?

@tmeidinger
Copy link
Author

tmeidinger commented Dec 9, 2023

192.168.0.0/24 is the local network. I want to go to 192.168.178.0/24 via a proxy.
https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing

There is no such thing as a Class B network.

@erosman erosman added duplicate This issue or pull request already exists area: localhost localhost bypass issues labels Dec 9, 2023
@erosman
Copy link
Collaborator

erosman commented Dec 9, 2023

Previously: #50

@tmeidinger
Copy link
Author

It seems to me as if this is a different issue. Localhost 127.0.0.1/8 is a different issue from 192.168.0.0/24 not being 192.168.0.0/16.

@erosman
Copy link
Collaborator

erosman commented Dec 9, 2023

FoxyProxy 8 is hardcoded to bypass proxy for localhost and local networks.
192.168.0.0/16 is often used for Wi-Fi modem/router and they shouldn't really be proxied.

The issue of local network proxy bypass is discussed in #50.

@tmeidinger
Copy link
Author

The internet is classless. If I'd like to route 192.168.0.0/30 (on the internal network) that's ok with every RFC I know. The same goes for proxying. There is absolutely no reason to exclude rfc6761 (former rfc1918) IP space.

@erosman
Copy link
Collaborator

erosman commented Dec 10, 2023

I am discussing the issue with the founder of FoxyProxy and some or all of localhost checks will be removed in v8.4

@erosman
Copy link
Collaborator

erosman commented Dec 10, 2023

It is done in v8.4
We are uploading v8.4 to AMO.
FoxyProxy Basic (same code) will be available shortly but FoxyProxy (standard) will take time due to the AMO review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: localhost localhost bypass issues done ✓ duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants