Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy entire tab if even one pattern matched #151

Open
kuhytitusdlz opened this issue Aug 27, 2024 · 6 comments
Open

proxy entire tab if even one pattern matched #151

kuhytitusdlz opened this issue Aug 27, 2024 · 6 comments
Labels
area: tab-proxy Tab Proxy related issues

Comments

@kuhytitusdlz
Copy link

Hi, thanks for foxyproxy!

It would be great to have an option to turn on the proxy for the entire tab if at least one pattern matches, because many sites access many third-party domains, and you have to add all these domains to the pattern

@erosman erosman added the area: tab-proxy Tab Proxy related issues label Aug 27, 2024
@erosman
Copy link
Collaborator

erosman commented Aug 27, 2024

There would be practical issues.

Cross browser compatibility

Tab based proxy is not possible on Chrome. It is only possible on Firefox due to its dedicated API.

Implementation Conflict

  • my.bank.com is not set to be proxied
  • fb.com is set to be proxied
  • my.bank.com has a widget from fb.com
  • Should the entire my.bank.com be proxied?

@kuhytitusdlz
Copy link
Author

let it be just firefox :-)

ok, I see conflict. Then can we look only first HTTP request, and match only them host header, and enable proxy for Tab?

@erosman
Copy link
Collaborator

erosman commented Aug 27, 2024

Then can we look only first HTTP request, and match only them host header, and enable proxy for Tab?

There is no set order in asynchronous operations.
The first may not be the one you have in mind which results in site A proxied sometimes and not others.

There can also be a reversed situation where user wants to proxy the top site and not the widget.

@kuhytitusdlz
Copy link
Author

I see this as an option when adding a pattern, whether the user wants to proxy only this URL/site, or the entire tab

can we catch the first request for a new tab, or when opening a tab via a link, and if the pattern matches, enable the proxy on the tab?

@d-g
Copy link

d-g commented Nov 8, 2024

ok, I see conflict. Then can we look only first HTTP request, and match only them host header, and enable proxy for Tab?

The first request must be to document.location (the uri, that is shown in the location bar).

You are aware of F***fox ‘containers’ feature, arenʼt you? FoxyProxy unfortunately has only a rudimentary support of it [0]; but maybe the eponymous webext [1] will actually cover all your needs?

[0] #33
[1] https://addons.mozilla.org/en-US/firefox/addon/multi-account-containers/

@kuhytitusdlz
Copy link
Author

o, thanks! I will try containers+foxyproxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tab-proxy Tab Proxy related issues
Projects
None yet
Development

No branches or pull requests

3 participants