Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure the minimum python version #9

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Nov 1, 2022

The Python version dissect is developed and tested against is currently 3.9. It
is set as minimum version and not also as maximum version because newer
versions (like 3.10) might work and because it makes transitioning to newer
Python versions easier.

(DIS-1490)

The Python version dissect is developed and tested against is currently 3.9. It
is set as minimum version and not also as maximum version because newer
versions (like 3.10) might work and because it makes transitioning to newer
Python versions easier.

(DIS-1490)
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #9 (e179dda) into main (85b090e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files          14       14           
  Lines        1212     1212           
=======================================
  Hits          991      991           
  Misses        221      221           
Flag Coverage Δ
unittests 81.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pyrco pyrco merged commit ad5b110 into main Nov 2, 2022
@pyrco pyrco deleted the feature/dis-1490_specify-minimum-python-version branch November 2, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants