Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour for custom resource Lambdas differs for alarms and dashboards #68

Open
eoinsha opened this issue Oct 25, 2021 · 0 comments
Open
Labels
bug Something isn't working

Comments

@eoinsha
Copy link
Contributor

eoinsha commented Oct 25, 2021

Describe the bug
When Lambda functions are injected by the serverless framework or other plugins for custom resources, these functions do not appear at the top-level functions block defined by the user in serverless.yml. An example of this is the function created by Serverless Framework when logs: {restApi: true} is enabled. In this case, a function is injected to create an IAM role so API Gateway can push logs to CloudWatch Logs (apiGatewayCloudWatchRole/handler.js).

As part of the resolution to issue #67, these functions are ignored for alarms. For dashboards, the function configuration handling is differently, so dashboard widgets are created for such functions by default. This is an inconsistency.

To Reproduce
In slic-starter (slic-watch branch), build the user-service using sls package

Expected behavior
Consistent behaviour for function-specific configuration in alarms and dashboards and clear behaviour for alarms and widgets relating to these "extra" functions.

@eoinsha eoinsha added the bug Something isn't working label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant