-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pretty printing abstraction #175
Labels
good first issue
Good for newcomers
Comments
Related #74 |
Protostar Abstaction 💀 |
Why do we need to introduce a new trait? Wouldn't be better to just use |
I don't think |
Closed
MaksymilianDemitraszek
added
good first issue
Good for newcomers
and removed
DONT DO - workshops
labels
Sep 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, all printing within the forge source code is done just by calling methods from this module:
https://github.com/foundry-rs/starknet-foundry/blob/master/crates/forge/src/pretty_printing.rs
We should introduce a PrettyPrinting trait that will define necessary methods. Current code existing in pretty printing module should be used for creating a default implementation of that trait.
Code should be changed (e.g. here
starknet-foundry/crates/forge/src/lib.rs
Line 222 in 621a1a5
The text was updated successfully, but these errors were encountered: