Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve script tx batch size logic #7583

Merged
merged 1 commit into from
Apr 7, 2024
Merged

chore: improve script tx batch size logic #7583

merged 1 commit into from
Apr 7, 2024

Conversation

DaniPopes
Copy link
Member

No description provided.

@DaniPopes DaniPopes requested review from mattsse and klkvr as code owners April 6, 2024 15:26
mattsse
mattsse approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might clash with @klkvr alloy pr

so defer to @klkvr in which order we want to include this

@klkvr
Copy link
Member

klkvr commented Apr 7, 2024

I think this should be OK to merge, doesn't really touch any providers/signers logic

@DaniPopes DaniPopes merged commit 72bc4f4 into master Apr 7, 2024
19 checks passed
@DaniPopes DaniPopes deleted the dani/batchsize branch April 7, 2024 08:48
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @klkvr @mattsse