Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new retryable ratelimit error #6751

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jan 9, 2024

@@ -84,6 +84,10 @@ fn should_retry_json_rpc_error(error: &ErrorPayload) -> bool {
return true
}

if *code == -32005 && message.contains("archive request rate exceeded") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment for it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, this is weird. it should have been caught by this already:

https://github.com/foundry-rs/foundry/blob/master/crates/common/src/provider/retry.rs#L77-L78

which makes me think that retryprovider is not properly configured or it's not properly handling the errors:

https://github.com/foundry-rs/foundry/blob/master/crates/common/src/provider/retry.rs#L31-L44

@mattsse mattsse force-pushed the matt/new-retry-error branch from 15b26de to bf1aa7b Compare January 9, 2024 21:01
@mattsse mattsse merged commit 05d6062 into foundry-rs:master Jan 9, 2024
17 of 19 checks passed
RPate97 pushed a commit to RPate97/foundry that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants