feat: add trace_filter RPC method #6410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Nov 23, 2023
There was a problem hiding this comment.
thanks for this.
we're currently in the process of migrating to reth's rpc types and tracer impl
so we can reuuse
https://github.com/paradigmxyz/reth/blob/3598a23cf7dfdaa254d6507677db9e419563b8da/crates/rpc/rpc-types/src/eth/trace/filter.rs#L11-L11
very soon.
The implementation of trace filter looks good, but can likely simplified as well once we migrated to reth's tracer impl.
I hope we can make much progress on this within the next few days so we can also include this PR here.
mike-code
force-pushed
the
foundry-4129/trace-filter-support
branch
from
e2e09da to
de2377b
Compare
mike-code
force-pushed
the
foundry-4129/trace-filter-support
branch
from
de2377b to
9dd44a0
Compare
|
Closing in favor of #8458 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#4129
Solution
I took a liberty of extending the the
filter_tracecall withmodeparameter which allows to specify whetherfromAddressandtoAddressshould be checked as a union or intersection. That is, if I pass two lists of bothfromandtoaddresses, should the trace addresses match both of them or either one of them. This isn't explicitly specified by the open ethereum docs so it makes sense to allow both and make it configurable.tbd