refactor: migrate to alloy providers #6219

onbjerg · 2023-11-05T21:16:30Z

Motivation

We want to migrate from Ethers to Alloy, which includes removing all references to Ether's Middleware trait and using Alloy equivalents (alloy-providers).

Solution

The API for providers is not final, so a temporary trait has been introduced to make migrating to the final API easier later on. Additionally, I will be removing code that is no longer needed (e.g. RuntimeClient), as well as adjusting everything that breaks downstream as a result of me changing the providers (e.g. forge script).

Todo

Adjust tests
Adjust docs
Resolve final breakages
Open up issues re: ergonomics with Alloy encountered during migration
Implement WebSocket and IPC support
Migrate Alchemy CU rate limiting mechanism as a Tower layer
Add retries as a tower layer on the transports

Depends on alloy-rs/alloy#20

* wip * fmt * wip * feat: start migrating basic types * more type changes across /eth and backend * wip type replacements * chore: replace mistaken type * feat: rpc types without pubsub migrated * chore: changes from rpc types * chore: re-add changes * feat: rpc types done, onto providers * we on that grind * feat: types migrated, tests remaining * chore: comment tests for now to get proper compile errors --------- Co-authored-by: Oliver Nordbjerg <[email protected]>

* chore: update doctests * chore: update cargo lock to make anvil test pass * chore: bump cargo lock again * fix: parse unit logics (#6713) --------- Co-authored-by: DaniPopes <[email protected]>

mattsse

okay, we need another pass and remove alloy ethers conversion where possible

crates/anvil/src/config.rs

crates/anvil/src/eth/api.rs

mattsse · 2024-01-05T17:58:17Z

crates/anvil/src/eth/api.rs

@@ -2446,7 +2522,7 @@ impl EthApi {

    /// Returns true if the `addr` is currently impersonated
    pub fn is_impersonated(&self, addr: Address) -> bool {
-        self.backend.cheats().is_impersonated(addr)
+        self.backend.cheats().is_impersonated(addr.to_ethers())


why no alloy

Also an storage type.

mattsse · 2024-01-05T18:00:02Z

crates/anvil/src/eth/backend/mem/storage.rs

+            base_fee: base_fee.map(|b| b.to_ethers()),
            gas_limit: env.block.gas_limit.to_ethers(),
            beneficiary: env.block.coinbase.to_ethers(),
            difficulty: env.block.difficulty.to_ethers(),


why still on ethers?

These are storage-related types and we agreed not to migrate them on this PR.

crates/anvil/src/lib.rs

crates/anvil/src/pubsub.rs

mattsse

more things to come!

onbjerg · 2024-01-08T12:07:25Z

I've tried looking at the ICE but I don't think there's a workaround. Should we merge with the ICE present?

Evalir · 2024-01-08T13:43:53Z

yep @onbjerg we can safely ignore the ICE for now—clippy won't run anyway until it's fixed.

@mattsse

* wip * fmt * wip * more wip * wip * wip * rebase stuff * more rebase stuff * wip * fmt * wip resolve warnings * wip * wip * wip * aaand cast started complaining gn * feat(`anvil`): RPC Types migration (foundry-rs#6256) * wip * fmt * wip * feat: start migrating basic types * more type changes across /eth and backend * wip type replacements * chore: replace mistaken type * feat: rpc types without pubsub migrated * chore: changes from rpc types * chore: re-add changes * feat: rpc types done, onto providers * we on that grind * feat: types migrated, tests remaining * chore: comment tests for now to get proper compile errors --------- Co-authored-by: Oliver Nordbjerg <[email protected]> * fix latest rebase errors * chore: `alloy-transports` -> `alloy-transport` (foundry-rs#6341) * fix: use new `TransportResult` (foundry-rs#6342) * fix: `TransportResult` for multi wallet (foundry-rs#6343) * feat: use TransportError on Anvil (foundry-rs#6344) * fix: uncomment serde tests, fix genesis test (foundry-rs#6346) * refactor: split ethers/alloy providers (foundry-rs#6378) * split ethers/alloy providers * chore: complete Transaction ToAlloy compat trait * chore: clone txs --------- Co-authored-by: Enrique Ortiz <[email protected]> * fix: block numbers are u64 (foundry-rs#6382) * fix: remove U64 cast (foundry-rs#6384) * chore(`anvil`): fix tests (foundry-rs#6383) * wip * chore: fix u64 * fix: access lists * chore: use latest ethers * silly ahhh otterscan test failing * more fixdy * almost done lesgo * pub sob * chre: fix otterscan test --------- Co-authored-by: Oliver Nordbjerg <[email protected]> * fix(anvil): port serde helpers, remove multiline jsons (foundry-rs#6404) * chore(`anvil`): extend alloy types until entry lib, cleanup warnings (foundry-rs#6413) * chore: extend alloy types until entry lib, cleanup warnings * chore: fix review comments * chore: pin alloy providers to repo & test fixup (foundry-rs#6414) * chore: pin alloy providers to repo * chore: fix doctests * clippy * clippy * clippy * fix fixtures * update * feat: reimplement rpc cheatcode * chore: fix warnings * chore: fmt, switch to local tx request type in the meanwhile for optimism tests * [Alloy providers migration]: Fix tests (foundry-rs#6462) * fix: properly return tx-only blocks instead of full blocks * chore: fix up fork tests * chore: mine blocks first before getting tx receipt * clippy/fmt * clippy * clippy * chore: add more delta for timestamp test * chore: fix up anvil API tests (foundry-rs#6517) * chore: fix up anvil API tests * fmt * feat: `RuntimeTransport` for `ws`/`ipc` support (foundry-rs#6525) * wip * chore: change to using the naked transport instead of an RpcClient<T> * chore: properly implement request * always poll ready * chore: docs * chore: clippy and other fixes * chore: use call to pass down the tower stack * chore: no unwraps * chore: new fn * feat: implement runtimetransport on the alloy provider builder * chore: refactor into separate functions depending on transport * feat: RuntimeTransportBuilder, refactor * feat: cleanup, docs * feat: IPC * clippy * cosmetics * feat: enable anvil ipc tests (foundry-rs#6570) * refactor: replace tracers with reth tracers (foundry-rs#6428) * wip * wip not working still -.- - gas reports - `forge script` cannot set `gas_used` for root trace since that requires mut access to the arena - event decoding not impl possibly broken - anvil traces (not tested) - test traces (not tested) - debugging (not tested) but hey, at least it compiles... * wip * chore: fix deps * remove utils import * chore: remove errors * chore: use render_trace_arena * derive debug * fix contract identification * fix formatting * remove stray todo * fix empty output * fix unrelated test :) --------- Co-authored-by: evalir <[email protected]> * fix lockfile * chore: fix anvil test * fixup: missing import * chore: lint * fixup: imports * fixup: more fixes * chore: fmt * clippy clippy clippy always clippy * and fmt * test: fix test * chore: add todo * clippy * feat(`anvil`/`evm`): re-add support for additional fields (foundry-rs#6573) * feat: re-add additional fields support * chore: clippy/fmt * bump Cargo.lock * chore: handle mixhash being optional (foundry-rs#6575) * fix: always ensure prevrandao is set (foundry-rs#6576) * chore: cleanup, reintroduce trace endpoints (foundry-rs#6577) * feat: re-enable debug_traceTransaction support (foundry-rs#6583) * chore: fix ipc test * chore: re-enable trace tests (foundry-rs#6586) * refactor: rm unused param * refactor: rm gas adjustment in script This should be solved in the tracer inspector itself already, cc @mattsse * chore: fix ci failures (foundry-rs#6595) * chore: use self.debug instead of self.verbose * chore: update lock * chore: fix deny check * feat(`RuntimeTransport`): port cups/retry logic (foundry-rs#6594) * some random stuff * fmt: toml * chore: use u64 in BlockRequest::Number * update * chore: remove some more ethers * chore: more ethers removals (units) * wip: remove reth * wip * rm ice * fix(`rpc-types`): use newer `alloy-rpc-types`, `alloy-rpc-trace-types` (foundry-rs#6705) * fix(rpc-types): use newer alloy-rpc-types, alloy-rpc-trace-types and reth inspectors * chore: remove ToReth * chore: fix imports * chore: quicknode retry (foundry-rs#6712) * fix(`general`): get ci green on 6219 (foundry-rs#6711) * chore: update doctests * chore: update cargo lock to make anvil test pass * chore: bump cargo lock again * fix: parse unit logics (foundry-rs#6713) --------- Co-authored-by: DaniPopes <[email protected]> * chore: remove borrows * chore: add removal note * chore: use alloy chains to compare * chore: remove some conversions, migrate feemanager/newblocknotifications * chore: clippy * chore: fix doctests --------- Co-authored-by: evalir <[email protected]> Co-authored-by: DaniPopes <[email protected]> Co-authored-by: Matthias Seitz <[email protected]>

This updates the docs to reflect that the `--verbose` flag was removed from `call`. See: foundry-rs/foundry#6939 foundry-rs/foundry#6219

This updates the docs to reflect that the `--verbose` flag was removed from `call`. See: foundry-rs/foundry#6939 foundry-rs/foundry#6219 Co-authored-by: tomholford <[email protected]>

onbjerg added A-evm Area: EVM Cmd-forge-test Command: forge test C-cast Command: cast C-forge Command: forge Cmd-forge-debug Command: forge run T-debt Type: code debt C-anvil Command: anvil Cmd-forge-script Command: forge script labels Nov 5, 2023

Evalir mentioned this pull request Nov 8, 2023

feat(anvil): RPC Types migration #6256

Merged

onbjerg added 9 commits November 13, 2023 00:52

wip

e4bc2c4

fmt

b9bb156

wip

186dc9d

more wip

dedb8df

wip

ec2bff3

wip

d7020f1

rebase stuff

dbec07d

more rebase stuff

4182c3f

wip

121b7bb

onbjerg force-pushed the onbjerg/alloy-providers branch from f70ccc5 to 121b7bb Compare November 13, 2023 01:09

onbjerg and others added 11 commits November 13, 2023 02:10

fmt

029a8ba

wip resolve warnings

f7280b1

wip

d63e380

wip

ebbe3f7

wip

621aedc

aaand cast started complaining gn

c98dfb7

Merge branch 'master' into onbjerg/alloy-providers

bd3efab

fix latest rebase errors

0177611

chore: alloy-transports -> alloy-transport (#6341)

8f55ab3

fix: use new TransportResult (#6342)

2f513fb

fix(general): get ci green on 6219 (#6711)

f984087

* chore: update doctests * chore: update cargo lock to make anvil test pass * chore: bump cargo lock again * fix: parse unit logics (#6713) --------- Co-authored-by: DaniPopes <[email protected]>

mattsse requested changes Jan 5, 2024

View reviewed changes

Evalir added 4 commits January 5, 2024 14:18

chore: remove borrows

cba1d93

chore: add removal note

87108d5

chore: use alloy chains to compare

78823ae

chore: remove some conversions, migrate feemanager/newblocknotifications

2f3ebba

Evalir requested review from mattsse and DaniPopes January 5, 2024 18:45

mattsse approved these changes Jan 5, 2024

View reviewed changes

This was referenced Jan 5, 2024

reth-revm-inspectors: Move inspectors out of reth and into their own repo paradigmxyz/reth#5956

Closed

Meta: Alloy migration #5216

Closed

onbjerg added 3 commits January 8, 2024 12:06

Merge branch 'master' into onbjerg/alloy-providers

025d27d

chore: clippy

41962ad

chore: fix doctests

526e91f

Evalir merged commit d46bcb3 into master Jan 8, 2024
19 of 20 checks passed

Evalir deleted the onbjerg/alloy-providers branch January 8, 2024 13:48

This was referenced Jan 9, 2024

Nightly consumes much more memory #6733

Closed

fix: dont record step tracing by default #6734

Merged

Thegaram mentioned this pull request Jan 19, 2024

Regression in forge script, fuzz: could not fetch slot {idx} from {address} #6855

Closed

2 tasks

DaniPopes mentioned this pull request Jan 29, 2024

fix(cast/call): remove --verbose, fix --debug #6939

Merged

tomholford added a commit to tomholford/book that referenced this pull request Jan 31, 2024

cast: update call flags

18bc02d

This updates the docs to reflect that the `--verbose` flag was removed from `call`. See: foundry-rs/foundry#6939 foundry-rs/foundry#6219

tomholford mentioned this pull request Jan 31, 2024

cast: update call flags foundry-rs/book#1108

Merged

vlad-blana mentioned this pull request Feb 15, 2024

Performance regression between 2bcb4a1 and 293fad7 #7131

Closed

2 tasks

This was referenced Apr 26, 2024

Reset to upstream phylaxsystems/phoundry#12

Merged

feat/forge bin as lib phylaxsystems/phoundry#13

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: migrate to alloy providers #6219

refactor: migrate to alloy providers #6219

onbjerg commented Nov 5, 2023 •

edited by Evalir

Loading

mattsse left a comment

mattsse Jan 5, 2024

Evalir Jan 5, 2024

mattsse Jan 5, 2024

Evalir Jan 5, 2024

mattsse left a comment

onbjerg commented Jan 8, 2024

Evalir commented Jan 8, 2024

refactor: migrate to alloy providers #6219

refactor: migrate to alloy providers #6219

Conversation

onbjerg commented Nov 5, 2023 • edited by Evalir Loading

Motivation

Solution

Todo

mattsse left a comment

Choose a reason for hiding this comment

mattsse Jan 5, 2024

Choose a reason for hiding this comment

Evalir Jan 5, 2024

Choose a reason for hiding this comment

mattsse Jan 5, 2024

Choose a reason for hiding this comment

Evalir Jan 5, 2024

Choose a reason for hiding this comment

mattsse left a comment

Choose a reason for hiding this comment

onbjerg commented Jan 8, 2024

Evalir commented Jan 8, 2024

onbjerg commented Nov 5, 2023 •

edited by Evalir

Loading