(feat) add conditional breakpoints #4801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Apr 22, 2023
|
sgtm! |
|
Wanted to do smth similar to vim-which-key help modal that would pop up over the debugger using contexts, but that was doing some underflow and not sure why. So it's resizing the main window to leave some space for the help footer and collapse on |
* fmt: abigens * Pass by reference when patching Hardhat selector rebase master
|
Seems like the conflicts doesn't resolve after a rebase |
|
@mattsse seems to be good now! |
|
@mattsse there have been a conflict fail, which is why you had to put the trailing "_" to make clippy happy here: https://github.com/iFrostizz/foundry/blob/556e0b4580f92a7f4f079d536416f33c695faae4/ui/src/lib.rs#L369-L382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implementing @mds1 's ideas about extending breakpoints, ref: #4679 (comment)
Changes
vm.breakpoint("a", true)to switch on andvm.breakpoint("a", false)to switch off)['<char>]: goto breakpointnotice on debugger footerAbout the notice
It's getting somewhat big and I cannot see the whole footer (about 2/3 currently) at once. Why not adding a
hto toggle help that would take more space, but could be collapsable ?