Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: forge fuzz/invariant benches #4723

Closed

Conversation

0xMelkor
Copy link
Contributor

Motivation

Propose a way to benchmark fuzz/invariant tests in forge (solves #3411)

Solution

Open points

  • Should we use forge/test/it/test_helpers to instantiate MultiContractRunner inside benches ?
  • Should we place new solidity tests inside ./testdata/ ?

@0xMelkor
Copy link
Contributor Author

Hi guys,

reading at discussions on this topic #999 #744 #4590 I think that the approach proposed in this PR does not meet the general requirement.

We don't need to measure blind execution performances, but instead:

  • Extend the configurability of the fuzz/invariant runner (i.e. to execute in a provided time window).
  • Return aggregated statistics at the end of the process.

The ability to benchmark the Forge runner against similar tools is just a consequence of the points above.

Closing this PR

@0xMelkor 0xMelkor closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant