Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to skip calculating root hashes in Anvil #8579

Open
Tracked by #8269
benwjhack opened this issue Aug 1, 2024 · 1 comment
Open
Tracked by #8269

Add an option to skip calculating root hashes in Anvil #8579

benwjhack opened this issue Aug 1, 2024 · 1 comment
Labels
A-reth-anvil Area: reth-anvil C-anvil Command: anvil T-feature Type: feature T-perf Type: performance T-post-V1 Area: to tackle after V1

Comments

@benwjhack
Copy link

benwjhack commented Aug 1, 2024

Component

Anvil

Describe the feature you would like

When doing simulations against anvil, a lot of time gets spent calculating root hashes. As far as I understand this is a proof of correctness, and is useful when multiple nodes are talking to each other; however in a simulation environment these hashes aren't useful. The simulation tooling I've been testing with (Compass Labs) shows that commenting out the lines which calculate these root hashes speeds things up the entire simulation by roughly 25%.

I would like it if there was some way to configure anvil to not calculate these root hashes. This configuration option could be something like "skip_root_hashes", or something like "single_node_simulation_environment", in case there are further options that make sense only for a simulation environment.

I would be happy to make an attempt to write this feature if people think it's a good idea, and I get advise on how best to do the configuration option.

Additional context

No response

@benwjhack benwjhack added the T-feature Type: feature label Aug 1, 2024
@zerosnacks zerosnacks added C-anvil Command: anvil T-perf Type: performance labels Aug 1, 2024
@zerosnacks zerosnacks added this to the v1.0.0 milestone Aug 1, 2024
@benwjhack
Copy link
Author

benwjhack commented Sep 19, 2024

See the fork in which I removed the hashes here - CompassLabs/foundry-test at do-not-hash

@jenpaff jenpaff removed this from the v1.0.0 milestone Sep 26, 2024
@grandizzy grandizzy added A-reth-anvil Area: reth-anvil T-post-V1 Area: to tackle after V1 labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-reth-anvil Area: reth-anvil C-anvil Command: anvil T-feature Type: feature T-perf Type: performance T-post-V1 Area: to tackle after V1
Projects
None yet
Development

No branches or pull requests

4 participants