-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: use dyn Database to reduce churn and binary size #8404
Comments
Generics currently allow us to recurse inside of inspectors by using such references:
how would we handle this when I think this is the only blocker rn, and one of the biggest pain points which I've also encountered when looking into custom precompiles, because |
In that case |
right, I think It'd have to be |
Component
Other (please describe)
Describe the feature you would like
Currently we pass around DB generic everywhere for very little gain. I believe if we used
Box<dyn Database>
or similar we could remove all of these generics, makeCheatcode
object-safe unifying it withDynCheatcode
, and generally deduplicate code.Made possible by recent improvements by @klkvr
Additional context
No response
The text was updated successfully, but these errors were encountered: