Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify verbosity logic of should_include between cast, test, coverage, script, etc.. #8339

Open
Tracked by #8794
zerosnacks opened this issue Jul 3, 2024 · 0 comments
Assignees
Labels
A-compatibility Area: compatibility A-internals Area: internals T-debt Type: code debt

Comments

@zerosnacks
Copy link
Member

Component

Forge, Cast

Describe the feature you would like

let should_include = match kind {
TraceKind::Setup => verbosity >= 5,
TraceKind::Execution => verbosity > 3,
_ => false,
} || !result.success;

Originally posted by @DaniPopes in #8224 (comment)

Additional context

No response

@zerosnacks zerosnacks added Cmd-forge-test Command: forge test C-cast Command: cast C-forge Command: forge T-debt Type: code debt Cmd-forge-script Command: forge script Cmd-forge-coverage Command: forge coverage A-compatibility Area: compatibility labels Jul 3, 2024
@zerosnacks zerosnacks added A-internals Area: internals and removed Cmd-forge-test Command: forge test C-cast Command: cast C-forge Command: forge Cmd-forge-script Command: forge script Cmd-forge-coverage Command: forge coverage labels Jul 16, 2024
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@jenpaff jenpaff removed this from the v1.0.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compatibility Area: compatibility A-internals Area: internals T-debt Type: code debt
Projects
None yet
Development

No branches or pull requests

2 participants