Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forge test): display block number used on fork tests #7574

Open
HrikB opened this issue Apr 5, 2024 · 2 comments
Open

feat(forge test): display block number used on fork tests #7574

HrikB opened this issue Apr 5, 2024 · 2 comments
Labels
C-forge Command: forge Cmd-forge-test Command: forge test P-low Priority: low T-feature Type: feature

Comments

@HrikB
Copy link

HrikB commented Apr 5, 2024 •
edited
Loading

Component

Forge

Describe the feature you would like

There are times that fork tests will fail on very specific blocks. Displaying the block number on which the fork test failed would be helpful in repro-ing the issue.

Ideally, this would show up even if there was no verbosity.

Additional context

No response
@HrikB HrikB added the T-feature Type: feature label Apr 5, 2024
@mattsse
Copy link
Member

mattsse commented Apr 5, 2024

@zerosnacks this can be combined with #7555 by including something like struct ForkInfo in the test result

@zerosnacks zerosnacks mentioned this issue Apr 9, 2024
Closed
@zerosnacks
Copy link
Member

Originally planned to be included in #7555 but ended up not being merged.

Feature request is still relevant and makes sense

@zerosnacks zerosnacks changed the title Display block number used on fork tests feat(forge test): display block number used on fork tests Jul 12, 2024
@zerosnacks zerosnacks added Cmd-forge-test Command: forge test C-forge Command: forge labels Jul 12, 2024
@zerosnacks zerosnacks removed their assignment Jul 12, 2024
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@grandizzy grandizzy added the P-low Priority: low label Oct 1, 2024
@grandizzy grandizzy removed this from the v1.0.0 milestone Nov 12, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-forge Command: forge Cmd-forge-test Command: forge test P-low Priority: low T-feature Type: feature
Projects
Foundry
Archived in project
Milestone
No milestone
4 participants
@mattsse @HrikB @grandizzy @zerosnacks