Non existent RPC URL fails after multiple retries without original error message

[DaniPopes]

Component

Forge, Cast

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

forge 0.2.0 (c61dc80 2024-01-26T00:21:42.044364394Z)

What command(s) is the bug in?

forge t --rpc-url doesnotexist

Operating System

Linux

Describe the bug

forge init test_
cd test_
forge t --rpc-url doesnotexist

Expected: fails instantly with not found error

Actual: retries 9 times, once every 800ms, fails with generic error:

Error:
Could not instantiate forked environment with fork url: doesnotexist

Context:
- Error #0: Failed to get latest block number
- Error #1: Error during transport: Max retries exceeded
- Error #2: Max retries exceeded
- Error #3: Max retries exceeded

Traces:

2024-01-26T19:41:19.676575Z TRACE alloy_rpc_client::call: Polling RpcCall self.state=Prepared
2024-01-26T19:41:19.676584Z TRACE poll: alloy_rpc_client::call: Polling prepared
2024-01-26T19:41:19.676595Z TRACE alloy_rpc_client::call: Polling RpcCall self.state=AwaitingResponse
2024-01-26T19:41:19.676597Z TRACE poll: alloy_rpc_client::call: Polling awaiting
2024-01-26T19:41:19.676624Z TRACE poll: foundry_common::provider::tower: retrying request due to Transport(Custom(TransportError(Transport(Custom(Os { code: 2, kind: NotFound, message: "No such file or directory" })))))

...

[mattsse]

@Evalir looks like we always retrying regardless of the error?

we should fail immediately on non retryable errors