Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm.startStateDiffRecording should record EXTCODE* and BALANCE opcodes as account accesses #6544

Closed
emo-eth opened this issue Dec 8, 2023 · 0 comments · Fixed by #6545
Closed

vm.startStateDiffRecording should record EXTCODE* and BALANCE opcodes as account accesses #6544

emo-eth opened this issue Dec 8, 2023 · 0 comments · Fixed by #6545
Labels
T-feature Type: feature

Comments

@emo-eth
Copy link
Contributor

emo-eth commented Dec 8, 2023 •
edited
Loading

Component

Forge

Describe the feature you would like

Current account access information is incomplete, since the EXTCODE* family of opcodes (extcodesize, extcodehash, extcodecopy) as well as BALANCE mark accessed accounts as warm.

Additional context

No response
@emo-eth emo-eth added the T-feature Type: feature label Dec 8, 2023
@gakonst gakonst added this to Foundry Dec 8, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 8, 2023
@emo-eth emo-eth mentioned this issue Dec 8, 2023
Merged
@emo-eth emo-eth changed the title vm.startStateDiffRecording should record EXT* opcodes as account accesses vm.startStateDiffRecording should record EXTCODE* and BALANCE opcodes as account accesses Dec 8, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-feature Type: feature
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(forge): account access cheatcode accounts for extcode* and balance opcodes emo-eth/foundry
1 participant
@emo-eth