Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fish_add_path in foundryup installation #6487

Closed
2 tasks done
bojidar-bg opened this issue Dec 1, 2023 · 0 comments
Closed
2 tasks done

Use fish_add_path in foundryup installation #6487

bojidar-bg opened this issue Dec 1, 2023 · 0 comments
Labels
T-bug Type: bug

Comments

@bojidar-bg
Copy link

Component

Foundryup

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (f5c9199 2023-12-01T00:19:29.279040779Z)

What command(s) is the bug in?

No response

Operating System

Linux

Describe the bug

The foundryup installation script (https://foundry.paradigm.xyz / foundryup/install) modifies config.fish directly, but fish shell provides a simpler / more idiomatic e.g. see Arch wiki way of modifying the path using fish_add_path. ence the following:

fish_add_path --append ~/.foundry/bin

will immediately add (realpath ~/.foundry/bin) at the end of PATH in all fish shells (deduplicated), and will persist it across reboots (due to how universal variables work in fish) -- there is no need to modify config.fish.

@bojidar-bg bojidar-bg added the T-bug Type: bug label Dec 1, 2023
@gakonst gakonst added this to Foundry Dec 1, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 1, 2023
@mattsse mattsse closed this as completed Feb 28, 2024
@jenpaff jenpaff moved this from Todo to Completed in Foundry Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
Archived in project
Development

No branches or pull requests

2 participants