Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: regression introduced in PR#5397 (remapping contexts) #5475

Closed
1 of 2 tasks
mds1 opened this issue Jul 25, 2023 · 0 comments · Fixed by #5532
Closed
1 of 2 tasks

bug: regression introduced in PR#5397 (remapping contexts) #5475

mds1 opened this issue Jul 25, 2023 · 0 comments · Fixed by #5532
Assignees
@Evalir
Labels
T-bug Type: bug

Comments

@mds1
Copy link
Collaborator

mds1 commented Jul 25, 2023

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

forge build

Operating System

None

Describe the bug

Seems #5397 was inadvertently a breaking change. Steps to reproduce:

  1. git clone https://github.com/gitcoinco/Alpha-Governor-Upgrade
  2. git checkout 17f7717
  3. forge build the repo using foundry commit d231a90f: build succeeds (this is the commit right before that PR)
  4. forge build the repo using foundry commit 8e365bee: build fails (this is the commit where that PR was merged)
@mds1 mds1 added the T-bug Type: bug label Jul 25, 2023
@gakonst gakonst added this to Foundry Jul 25, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Jul 25, 2023
@mds1 mds1 changed the title bug: regression from https://github.com/foundry-rs/foundry/pull/5397 bug: regression introduced in PR#5397 (remapping contexts) Jul 25, 2023
This was referenced Jul 27, 2023
Merged
Merged
@Evalir Evalir mentioned this issue Aug 3, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evalir Evalir

Labels
T-bug Type: bug
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(forge): Dedup remappings on build correctly & do not set context by default foundry-rs/foundry
2 participants
@mds1 @Evalir