Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for solc 0.8.21 #5436

Closed
pcaversaccio opened this issue Jul 19, 2023 · 6 comments · Fixed by #5459
Closed

Add support for solc 0.8.21 #5436

pcaversaccio opened this issue Jul 19, 2023 · 6 comments · Fixed by #5459

Comments

@pcaversaccio
Copy link
Contributor

https://github.com/ethereum/solidity/releases/tag/v0.8.21

@gakonst gakonst added this to Foundry Jul 19, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Jul 19, 2023
@pcaversaccio
Copy link
Contributor Author

Cc: @roynalnaruto @mattsse

@pcaversaccio
Copy link
Contributor Author

For anyone coming here, you can now access events from other contracts (this will help with Foundry tests)!

image

@mattsse
Copy link
Member

mattsse commented Jul 19, 2023

fyi @Evalir need to build and publish new svm-rs

@Evalir
Copy link
Member

Evalir commented Jul 19, 2023

on it chief

@pcaversaccio
Copy link
Contributor Author

For anyone interested, I also added support for dapptools already dapphub/dapptools#987

@pcaversaccio
Copy link
Contributor Author

For anyone interested in the new event-selecting feature, there is an unfortunate ICE in Solidity due to NatSpec parsing: ethereum/solidity#14430. For anyone who wants to use that feature and compiles with a mode that requires NatSpec parsing need to wait for solc 0.8.22. Example of a contract which will not compile unfortunately:

// SPDX-License-Identifier: MIT
pragma solidity 0.8.21;

contract X {
    event E();
}

contract C {
    function g() public {
        emit X.E();
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants