-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cast lookup-address
and resolve-name
fail on names with unicode characters
#5386
Comments
Ah thanks for the issue, noticed this earlier and was wondering if the contract was misconfigured or if it was an issue with the emoji
This is because you can set the reverse record to resolve to any ENS name you want. So the proper way to do reverse lookups (address -> ENS) is to first do the reverse lookup (address -> ENS), then do a forward lookup (ENS -> address) and verify you get back the original address. So you see this error on the forward lookup step |
Can I take this one? |
@Sabnock01 assigned! |
This appears to be an error in |
@Evalir this has been merged. Do we just bump |
Yep we're bumping it on #5397 already |
This is working for me on |
Can confirm it's working! Thanks for the ping @Sabnock01 — closing |
Component
Cast
Have you ensured that all of these are up to date?
What version of Foundry are you on?
forge 0.2.0 (e488e2b 2023-07-10T15:17:42.605282000Z)
What command(s) is the bug in?
cast lookup-address, cast resolve-name
Operating System
macOS (Apple Silicon)
Describe the bug
ENS names without unicode characters resolve correctly in both directions
ENS names with unicode characters result in errors – although, interestingly, lookup-address fails by saying it couldn't look up the correctly resolved name.
The text was updated successfully, but these errors were encountered: