Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge script fails to verify on mumbai #5170

Closed
1 of 2 tasks
thedavidmeister opened this issue Jun 16, 2023 · 4 comments
Closed
1 of 2 tasks

forge script fails to verify on mumbai #5170

thedavidmeister opened this issue Jun 16, 2023 · 4 comments
Labels
T-bug Type: bug

Comments

@thedavidmeister
Copy link

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

forge script

Operating System

Linux

Describe the bug

as seen here in CI https://github.com/rainprotocol/rain.orderbook/actions/runs/5291795497/jobs/9577824407

forge script deploys a contract but fails to verify it

We haven't found any matching bytecode for the following contracts: [0xe80e098a8379eee4c05100e36088fd13e9e7b9b3].

This may occur when resuming a verification, but the underlying source code or compiler version has changed.

This seems strange to me as the code should be built and deployed as-is by CI without any modifications or "resuming" a verification.

@thedavidmeister thedavidmeister added the T-bug Type: bug label Jun 16, 2023
@gakonst gakonst added this to Foundry Jun 16, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Jun 16, 2023
@Evalir
Copy link
Member

Evalir commented Jun 16, 2023

Ref #5168

@thedavidmeister
Copy link
Author

thedavidmeister commented Jun 16, 2023

it verifies now strangely even with the same error https://github.com/rainprotocol/rain.orderbook/actions/runs/5291881682/jobs/9578030758?pr=1

i made a couple of changes

  • i ran forge fmt
  • a dependency had an import like src/... rather than ./ which was breaking slither compilation, maybe that caused verification to struggle too

@Evalir
Copy link
Member

Evalir commented Jun 16, 2023

interesting—the path issue might cause verification problems as well yeah. We've documented this problem in another issue.

Once we merge the actual fix on ethers and bump i'll close this issue

@Evalir
Copy link
Member

Evalir commented Jun 19, 2023

Closing, we merged #5167 and will be available in the next nightly

@Evalir Evalir closed this as completed Jun 19, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
Archived in project
Development

No branches or pull requests

2 participants