Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making content-type application/json header optional #2930

Open
Tracked by #8269
mattsse opened this issue Aug 24, 2022 · 0 comments
Open
Tracked by #8269

Consider making content-type application/json header optional #2930

mattsse opened this issue Aug 24, 2022 · 0 comments
Labels
A-internals Area: internals C-anvil Command: anvil T-feature Type: feature

Comments

@mattsse
Copy link
Member

mattsse commented Aug 24, 2022

Component

Anvil

Describe the feature you would like

geth requires "Content-Type: application/json", while dev nodes like ganache,hh or providers do not.

in anvil this is enforced by axum::Json type which treats missing content-type as an error with no way to opt out.

this could only be resolved by rolling a custom Json wrapper

Additional context

No response
@mattsse mattsse added T-feature Type: feature C-anvil Command: anvil labels Aug 24, 2022
@gakonst gakonst added this to Foundry Aug 24, 2022
@gakonst gakonst moved this to Todo in Foundry Aug 24, 2022
@zerosnacks zerosnacks mentioned this issue Jun 27, 2024
Open
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@zerosnacks zerosnacks added the A-internals Area: internals label Aug 2, 2024
@zerosnacks zerosnacks removed this from the v1.0.0 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-internals Area: internals C-anvil Command: anvil T-feature Type: feature
Projects
Foundry
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @zerosnacks