Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: forge snapshot should remove --include-fuzz and use a hardcoded fuzz_seed #2553

Closed
mds1 opened this issue Aug 2, 2022 · 0 comments · Fixed by #2591
Closed

feat: forge snapshot should remove --include-fuzz and use a hardcoded fuzz_seed #2553

mds1 opened this issue Aug 2, 2022 · 0 comments · Fixed by #2591
Assignees
@onbjerg
Labels
A-gas-snapshots Area: gas snapshotting/reporting C-forge Command: forge Cmd-forge-test Command: forge test first issue A good way to start contributing T-feature Type: feature

Comments

@mds1
Copy link
Collaborator

mds1 commented Aug 2, 2022

Component

Forge

Describe the feature you would like

Ref #1658 which adds support for deterministic fuzzing.

Previously, an --include-fuzz flag was added to forge snapshot in order to ensure deterministic gas snapshot results. The snapshot interface can be simplified while also executing more runs for snapshot data by:

  • Removing the --include-fuzz flag.
  • Modifying forge snapshot to always use the same rng seed. The value used doesn't really matter here, maybe we just use 0 or 1.

Potentially related gas snapshot issues:

Additional context

No response
@mds1 mds1 added the T-feature Type: feature label Aug 2, 2022
@gakonst gakonst added this to Foundry Aug 2, 2022
@gakonst gakonst moved this to Todo in Foundry Aug 2, 2022
@onbjerg onbjerg added Cmd-forge-test Command: forge test C-forge Command: forge A-gas-snapshots Area: gas snapshotting/reporting first issue A good way to start contributing labels Aug 3, 2022
@onbjerg onbjerg self-assigned this Aug 3, 2022
@onbjerg onbjerg moved this from Todo to In Progress in Foundry Aug 3, 2022
@onbjerg onbjerg mentioned this issue Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onbjerg onbjerg

Labels
A-gas-snapshots Area: gas snapshotting/reporting C-forge Command: forge Cmd-forge-test Command: forge test first issue A good way to start contributing T-feature Type: feature
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: snapshot fuzz tests using deterministic seed foundry-rs/foundry
2 participants
@onbjerg @mds1