Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip Cargo.toml from consistency checks #1701

Closed
meetmangukiya opened this issue May 23, 2022 · 0 comments
Closed

Option to skip Cargo.toml from consistency checks #1701

meetmangukiya opened this issue May 23, 2022 · 0 comments
Labels
T-feature Type: feature

Comments

@meetmangukiya
Copy link
Contributor

Component

Forge

Describe the feature you would like

Right now without --overwrite passed forge bind generates and checks the bindings for consistency, i.e. if they require to be updated. In a monorepo structure like http://github.com/gakonst/foundry-rust-template you are usually using the bindings crate in your app, and ethers version should be consistent between the two for being able to use the bindings crate in the app. Currently, bindings are generated with default-features = false and git master branch. If the user is using different version of ethers or ones with additional features like ws, ipc, rustls, etc. the ethers_providers versions mismatch and you are not able to use the bindings crate in the app anymore.

Ability to skip Cargo.toml from consistency checks would allow users to manage the ethers version themselves and as suitable to them while also not giving up on consistency checks.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature Type: feature
Projects
Archived in project
Development

No branches or pull requests

1 participant