Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow --revert-strings flag to pass to compiler for forge build #1375

Closed
peter-ciccolo opened this issue Apr 21, 2022 · 0 comments · Fixed by #1377
Closed

Allow --revert-strings flag to pass to compiler for forge build #1375

peter-ciccolo opened this issue Apr 21, 2022 · 0 comments · Fixed by #1377
Assignees
@mattsse
Labels
C-forge Command: forge Cmd-forge-build Command: forge build D-easy Difficulty: easy P-normal Priority: normal T-feature Type: feature

Comments

@peter-ciccolo
Copy link

Component

Forge

Describe the feature you would like

The solidity compiler accepts a revertStrings config which allows user-supplied revert strings to be stripped (for bytecode size) or for EVM revert strings to be added (for debugging). As far as I can tell this is not currently accessible through forge build.

Additional context

Config can be found here: https://docs.soliditylang.org/en/v0.8.13/using-the-compiler.html
@peter-ciccolo peter-ciccolo added the T-feature Type: feature label Apr 21, 2022
@onbjerg onbjerg added this to Foundry Apr 21, 2022
@onbjerg onbjerg moved this to Todo in Foundry Apr 21, 2022
This was referenced Apr 21, 2022
Merged
Merged
@onbjerg onbjerg added C-forge Command: forge P-normal Priority: normal Cmd-forge-build Command: forge build D-easy Difficulty: easy labels Apr 21, 2022
@onbjerg onbjerg moved this from Todo to In Progress in Foundry Apr 21, 2022
Repository owner moved this from In Progress to Done in Foundry Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsse mattsse

Labels
C-forge Command: forge Cmd-forge-build Command: forge build D-easy Difficulty: easy P-normal Priority: normal T-feature Type: feature
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for revert strings mattsse/foundry
3 participants
@onbjerg @mattsse @peter-ciccolo