Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put fuzz test snapshots behind a flag #1081

Closed
transmissions11 opened this issue Mar 28, 2022 · 0 comments · Fixed by #1086
Closed

Put fuzz test snapshots behind a flag #1081

transmissions11 opened this issue Mar 28, 2022 · 0 comments · Fixed by #1086
Labels
T-feature Type: feature

Comments

@transmissions11
Copy link
Contributor

transmissions11 commented Mar 28, 2022 •
edited
Loading

Component

Forge

Describe the feature you would like

forge snapshot currently exports the median and mean gas usage for fuzz tests

this makes using forge snapshot for gas optimizing near impossible, as the numbers for fuzz tests will vary wildly even if no actual change to the contract's gas usage was made (due to the random nature of the inputs)

imo we should not show fuzz tests in the snapshots by default, and only show them if --snapshot-fuzz-tests is passed as a flag or a similar config option is set

Additional context

alternatively replace forge snapshot with #887 (my preferred choice)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

forge: keep fuzz snapshots behind a flag
1 participant
@transmissions11