Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add note about evm_version being derived from Etherscan and sometimes making the incorrect assumption. #1316

Open
zerosnacks opened this issue Sep 26, 2024 · 0 comments
Assignees

Comments

@zerosnacks
Copy link
Member

zerosnacks commented Sep 26, 2024

Because Etherscan sometimes returns default evmVersion we automatically derive from the compiler version and make a best-guess assumption. This sometimes leads to issues.

Related: https://github.com/foundry-rs/foundry/pull/8369/files

This would resolve by documenting it as there is no clear solution:

@zerosnacks zerosnacks self-assigned this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Todo
Development

No branches or pull requests

1 participant