Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm: boards: stm32 eval: fix flashing instructions #777

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vanmaegima
Copy link
Member

The flash layouts file was renamed to FlashLayout_emmc.tsv. Explicitly enter the correct directory to run the flashing command.

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

The flash layouts file was renamed to FlashLayout_emmc.tsv.
Explicitly enter the correct directory to run the flashing command.

Signed-off-by: Vanessa Maegima <[email protected]>
@doanac
Copy link
Member

doanac commented Nov 28, 2024

@vanmaegima
Copy link
Member Author

vanmaegima commented Nov 28, 2024

I'm unsure if the renaming is correct or if we are just not publishing the correct flashlayout file, can you confirm @igoropaniuk ?
After testing, I see that flashing from the FlashLayout_emmc.tsv file does not work at least for the published v94.1 release.

@vanmaegima vanmaegima marked this pull request as draft November 28, 2024 20:06
@igoropaniuk
Copy link
Contributor

@vanmaegima I'll take a look.
If you still have a flashing log (or at least the error message you're observing), could you share it?

@vanmaegima
Copy link
Member Author

As discussed on Slack, this seems to be related to flashing unsigned -sec binaries on an open board. I will re-test it and report back.

@vanmaegima vanmaegima marked this pull request as ready for review December 3, 2024 18:04
Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants