Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add where to set uefi variables #759

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

kprosise
Copy link
Contributor

Follow up to Slack discussion, the file the variables UEFI_SIGN_ENABLE and UEFI_SIGN_KEYDIR are set in was mentioned, as well as an admonition mentioning the case where this is not required.

QA steps: ran build and checked rendered HTML, ran linter. No issues found.

No related ticket, quick fix.

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Let me know if I need to change anything, such as the file, or any unclear wording in the admonition.

Follow up to Slack discussion, the file the variables `UEFI_SIGN_ENABLE`
`and UEFI_SIGN_KEYDIR` are set in was mentioned, as well as an
admonition mentioning the case where this is not required.

QA steps: ran build and checked rendered HTML, ran linter. No issues
found.

No related ticket, quick fix.

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise requested review from vanmaegima and a team October 15, 2024 07:48
@doanac
Copy link
Member

doanac commented Oct 15, 2024

Copy link
Member

@vanmaegima vanmaegima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kprosise kprosise merged commit c3680fb into foundriesio:main Oct 16, 2024
3 checks passed
@kprosise kprosise deleted the add-uefi-enable-location branch October 16, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants