Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm: boards: Use compressed image with mfgtool files #596

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

angolini
Copy link
Collaborator

Since foundriesio/meta-lmp#1279 we are using compressed image in the uuu script for full image flashing.

Readiness

To be merged after foundriesio/meta-lmp#1279 is merged

Checklist

  • View HTML in a browser to check rendering.

@angolini angolini requested review from kprosise, Tim-Anderson and a team September 14, 2023 13:07
@doanac
Copy link
Member

doanac commented Sep 14, 2023

Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will go ahead and merge (after meta-lmp#1279)

@EmbeddedAndroid
Copy link
Contributor

I'm worried about existing customers / partner factories not using the latest version. i.e. if I look at the latest docs, I'm running v90, the instructions are now wrong. Is it possible to be backward compatible?

@kprosise
Copy link
Contributor

@EmbeddedAndroid So this effects older releases? If need be we could edit the older docs to add an admonition, though of course this is less than ideal.

@angolini
Copy link
Collaborator Author

@EmbeddedAndroid do we have partner factories using NXP reference boards? My initial thought is that it would only affect the reference boards, so it would not propagate to the other/older uuu scripts.

@EmbeddedAndroid
Copy link
Contributor

@kprosise @angolini I have two main concerns:

  1. Arduino, Adlink, and Phytec partner factories are imx8 based, but not on the latest release. v85, v89, and v91.
  2. I don't think we can control folks looking at the latest version of the docs, but maybe add a note saying if your running an older release i.e. v91 and older you need to use flashing instructions from the corresponding release?

@angolini
Copy link
Collaborator Author

@EmbeddedAndroid IMHO, this note should be in the footer or header and be visible on every page. What do you think about adding a note on which version this was changed, something like:

"The compressed image started to be used in v92. Before that, the uncompressed image was used instead."

@EmbeddedAndroid
Copy link
Contributor

@EmbeddedAndroid IMHO, this note should be in the footer or header and be visible on every page. What do you think about adding a note on which version this was changed, something like:

"The compressed image started to be used in v92. Before that, the uncompressed image was used instead."

I like that idea +1!

Since foundriesio/meta-lmp#1279 we are using
compressed image in the uuu script for full image flashing.

Signed-off-by: Daiane Angolini <[email protected]>
@angolini angolini force-pushed the uncompressed-full-image branch from 5a89b9a to e656f80 Compare September 26, 2023 17:23
@angolini
Copy link
Collaborator Author

change pushed @EmbeddedAndroid @kprosise

@doanac
Copy link
Member

doanac commented Sep 26, 2023

@EmbeddedAndroid
Copy link
Contributor

lgtm @angolini

@kprosise kprosise merged commit 288bd30 into foundriesio:main Sep 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants