Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm: security: The variable UBOOT_SIGN_ENABLE from factory is deprecated #592

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

angolini
Copy link
Collaborator

@angolini angolini commented Aug 31, 2023

The variable is deprecated since:
foundriesio/ci-scripts#306

@angolini angolini requested review from vanmaegima and a team August 31, 2023 21:10
@doanac
Copy link
Member

doanac commented Aug 31, 2023

Copy link
Member

@vanmaegima vanmaegima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this is the initial change and we will do future changes for our recommendations regarding this variable, so approved.

@angolini
Copy link
Collaborator Author

angolini commented Sep 4, 2023

Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will go ahead and merge

@kprosise kprosise merged commit 1e90eed into foundriesio:main Sep 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants