Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drilldown _hideAll does not work in 6.7.x #12308

Closed
3 tasks done
driskell opened this issue Nov 2, 2021 · 3 comments · Fixed by #12322
Closed
3 tasks done

Drilldown _hideAll does not work in 6.7.x #12308

driskell opened this issue Nov 2, 2021 · 3 comments · Fixed by #12322

Comments

@driskell
Copy link

driskell commented Nov 2, 2021

What should happen?

When calling $element.foundation('_hideAll') on a Drilldown which is currently in a submenu should restore it to the root.

What happens instead?

The Drilldown menu disappears

Possible Solution

I believe a regression in #12038 caused this - as it adds new invisible classes to aid in keyboard navigation. However, the invisible class added to the root menu is not removed in a call to _hideAll, and so the submenu is hidden and the root menu never re-appears.

Test Case and/or Steps to Reproduce (for bugs)

Test Case on 6.7.3: https://codepen.io/Driskell/pen/oNeoJpa
Compare to 6.6.3 which works: https://codepen.io/Driskell/pen/NWvwmxW

Context

N/A

Your Environment

  • Foundation version(s) used: 6.7.3
  • Browser(s) name and version(s): Chrome 95 but also present in all other browsers
  • Device, Operating System and version: macOS Monterey
  • Link to your project: N/A

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • There are no other issues similar to this one.
  • The issue title and template are correctly filled.
@pebutler3
Copy link
Contributor

@joeworkman can I take this one?

@joeworkman
Copy link
Member

joeworkman commented Nov 5, 2021

Go for it Mr. Butler! 😀

@driskell
Copy link
Author

Thanks @pebutler3 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants