Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add target="_blank" attribute to <item> within <menu> #465

Closed
antonydjames opened this issue Jun 8, 2016 · 3 comments
Closed

Cannot add target="_blank" attribute to <item> within <menu> #465

antonydjames opened this issue Jun 8, 2016 · 3 comments

Comments

@antonydjames
Copy link

antonydjames commented Jun 8, 2016

How can we reproduce this bug?

<menu><item href="http://www.address.com/" target="_blank"></item></menu>

What did you expect to happen?

The hyperlink within the 'item' component to contain the target="_blank" attribute, so that links clicked by users via a web email client are guaranteed to open in a new tab/window, no matter the client's default action. This doesn't need to apply by default, but ideally we should have the option to include it.

What happened instead?

The hyperlink does not include the target="_blank" attribute.

What email clients does this happen in?

All inlined HTML, ergo all web clients.

This is a similar issue to #432 though that applies to 'button' Inky elements rather than 'item' ones.

@rafibomb
Copy link
Member

rafibomb commented Jun 8, 2016

Looks like the PR that solves this for buttons can be easily extended to menu items - foundation/inky#42 Is that something you can help with?

@rafibomb
Copy link
Member

Awesome PR by @ClementParis016 foundation/inky#54

@ClementParis016
Copy link

Thanks, I'm glad to contribute to this nice project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants