-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Acceleration Patcher and MultiPack Plugin #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianlim
force-pushed
the
accel-patcher
branch
from
August 16, 2024 09:09
1d3f481
to
df48960
Compare
@achew010 we have merged #66 now. so I will rebase this PR.
|
fabianlim
force-pushed
the
accel-patcher
branch
from
August 19, 2024 13:13
df48960
to
b98d80e
Compare
7 tasks
Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: 1000850000 user <[email protected]> Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: 1000850000 user <[email protected]> Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Co-authored-by: Yu Chin Fabian Lim <[email protected]> Signed-off-by: 1000850000 user <[email protected]> Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: 1000850000 user <[email protected]> Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: 1000850000 user <[email protected]> Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: 1000850000 user <[email protected]> Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: 1000850000 user <[email protected]> Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Co-authored-by: Yu Chin Fabian Lim <[email protected]> Signed-off-by: 1000850000 user <[email protected]> Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: 1000850000 user <[email protected]> Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: 1000850000 user <[email protected]> Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Co-authored-by: Yu Chin Fabian Lim <[email protected]> Signed-off-by: 1000850000 user <[email protected]> Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: 1000850000 user <[email protected]> Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: 1000850000 user <[email protected]> Signed-off-by: Yu Chin Fabian Lim <[email protected]>
Signed-off-by: Yu Chin Fabian Lim <[email protected]>
fabianlim
force-pushed
the
accel-patcher
branch
from
August 23, 2024 08:21
286c514
to
3c5aca0
Compare
Signed-off-by: Yu Chin Fabian Lim <[email protected]>
We have integrated the changes from the PR #71. Merging but the orca dataset is a bit small for the tests. |
achew010
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR to be merged after #66
This PR adds the
AccelerationPatcher
and the multipack plugin.AccelerationPatcher
intoframework
to patch the acceleration object.AccelerationPatcher
only has areplace
rule, but in the future we could support other things, such as performing customized distributed loss reductions.Benchmarks
Mistral7B on Flan Subset (6000 samples)
NOTE: this
scenarios-flan.yaml
is not published as it links to an internally prepared flan.Run
bash scripts/run_benchmarks.sh "2 4 8" "16 32 64" benchmark_outputs scenarios-flan.yaml "padding-free"
Mistral7B on OrcaMath Subset (8000 samples)
Run
bash scripts/run_benchmarks.sh "2 4 8" "16 32 64 128" benchmark_outputs scenarios-orca.yaml "padding-free"