Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "homepage" optional in Cargo.toml #22

Closed
bunburya opened this issue Feb 24, 2024 · 1 comment · Fixed by #23
Closed

Make "homepage" optional in Cargo.toml #22

bunburya opened this issue Feb 24, 2024 · 1 comment · Fixed by #23

Comments

@bunburya
Copy link
Contributor

This tool appears to fail if the homepage field is not specified in Cargo.toml. C-METADATA, which is linked in the README, states that homepage is optional and further states:

The homepage metadata should only be set if there is a unique website for the crate other than the source repository or API documentation. Do not make homepage redundant with either the documentation or repository values. For example, serde sets homepage to https://serde.rs, a dedicated website.

Given that a lot of crates these days will just have a repository URL and not a separate homepage, I think it would be good to make homepage optional in cargo-aur (following the approach in C-METADATA). The url field in the PKGBUILD could be set to homepage or, if that is not present, documentation or, if that is not present, repository (the last being a required field per C-METADATA).

Happy to work on a PR for this if helpful.

@fosskers
Copy link
Owner

Great suggestion. Want to give it a shot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants