Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNG Speaker Images not rendered as Icons on Schedule #2238

Open
mariobehling opened this issue Mar 7, 2020 · 5 comments
Open

PNG Speaker Images not rendered as Icons on Schedule #2238

mariobehling opened this issue Mar 7, 2020 · 5 comments
Labels
Milestone

Comments

@mariobehling
Copy link
Member

If a speaker provided a png image the thumbnail images are not rendered in the schedule and tracks pages.

Screenshot from 2020-03-07 22-26-12
compare https://summit.fossasia.org/event/schedule.html#5838

@dhruvjain99
Copy link
Contributor

@mariobehling @iamareebjamal I checked out the code and verified that the png images of speakers are rendering fine. I found out that images with names as for example Tomaž Vajngerl are rendered as the attached image. I only found out for such cases the issue is there, the rest is working fine.
image

@mariobehling
Copy link
Member Author

@djcruz93 So, the issue is that International characters e.g. from UTF8 are not rendered properly. Any chance to fix this?

@iamareebjamal
Copy link
Member

@djcruz93 The best solution is to randomize image names which will also solve the issue of wrong speaker images

@dhruvjain99
Copy link
Contributor

@mariobehling @iamareebjamal this can be resolved by removing encodeURI as after downloading the image, the file name is not encoded but while generating the js object for speaker, we have used encodedURI. I am able to resolve this for zip upload. But I would like to test for api version. @mariobehling can you please give me the event api for which you faced this issue? So that I can reproduce and check with the changes.
image

@Manishgupta200
Copy link

I want to solve it .. Plaese assign it to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

4 participants