Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to actively maintained Fomantic-UI (backwards compatible) #16

Closed
lubber-de opened this issue Jul 14, 2020 · 2 comments
Closed

Switch to actively maintained Fomantic-UI (backwards compatible) #16

lubber-de opened this issue Jul 14, 2020 · 2 comments

Comments

@lubber-de
Copy link

Semantic UI has'nt been maintained since 2018, but the active community fork https://fomantic-ui.com already got 500 bugfixes and new features like calendar, slider, toast, etc.

it is backward compatible, the current code should work as it is.

https://fomantic-ui.com
https://github.com/fomantic/fomantic-ui

@iamareebjamal
Copy link
Member

Yes, we've planned to try it out and will soon comment if we need any help. Thanks a lot for reaching out :)

@iamareebjamal
Copy link
Member

iamareebjamal commented Aug 10, 2020

We tried fomantic UI here fossasia/open-event-frontend#4538 but it caused modals (fomantic/Fomantic-UI#1590) and nested popups to break fossasia/open-event-frontend#4730 and fossasia/open-event-frontend#4735

So, we cherry-picked the fix for scroll lock from this PR fomantic/Fomantic-UI#273 in d2473e5 and everything is working now.

  • Dimmer close on cross button
  • Dimmer is not repeated on interaction
  • Scroll lock doesn't happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants