Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly calculated offset for loading new items #774

Closed
jtojnar opened this issue Jun 12, 2016 · 0 comments
Closed

Incorrectly calculated offset for loading new items #774

jtojnar opened this issue Jun 12, 2016 · 0 comments
Labels
bug

Comments

@jtojnar
Copy link
Member

jtojnar commented Jun 12, 2016

When you mark some source items as read and then scroll down to load more, it loads items with the same offset as if you did not read anything, causing some items to be skipped.

selfoss-queue

The offset when loading new items should be decreased by the number of items marked as read.
@jtojnar jtojnar mentioned this issue Dec 29, 2016
Merged
niol added a commit to niol/selfoss that referenced this issue Jan 2, 2017
@niol
use seek pagination instead of offset
1aff08c 
- slightly better performance
- easier to read than extra explicitely requested entries for fixing fossar#774
jtojnar pushed a commit that referenced this issue Feb 5, 2017
@niol @jtojnar
ensure read items are counted for loading more items (fix #774)
c1469f3
jtojnar pushed a commit that referenced this issue Feb 5, 2017
@niol @jtojnar
use seek pagination instead of offset
f307877 
- slightly better performance
- easier to read than extra explicitely requested entries for fixing #774
niol added a commit to niol/selfoss that referenced this issue Feb 6, 2017
@niol
ensure read items are counted for loading more items (fix fossar#774)
f9db3dc
niol added a commit to niol/selfoss that referenced this issue Feb 6, 2017
@niol
use seek pagination instead of offset
5427a2f 
- slightly better performance
- easier to read than extra explicitely requested entries for fixing fossar#774
@jtojnar jtojnar reopened this Feb 6, 2017
jtojnar pushed a commit that referenced this issue Feb 12, 2017
@niol @jtojnar
use seek pagination instead of offset
77f1589 
- slightly better performance
- easier to read than extra explicitely requested entries for fixing #774
@jtojnar jtojnar added the bug label Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtojnar