Rework Authentication into separate services #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for selfoss canceled.
|
jtojnar
force-pushed
the
auth
branch
3 times, most recently
from
58d8664
to
a36d706
Compare
So that it does not try to access `$_SERVER['SERVER_NAME']` in CLI SAPI. Though this is not sufficient, since the Authentication helper will try to access it strictly too.
So that we do not need to care about it in the Authentication rewrite later.
Otherwise unexpected success will not be caught.
Rename authorization levels to `read`/`update`/`privileged` and explicitly document them.
This is a from-scratch rewrite, moving a bit closer to Single Responsibility Principle. We split handling of credentials-in-config and always-open authentication systems. In the future, we will be able implement more methods this way. This was motivated by session code being called in constructor, which would break in CLI with Tracy strict mode. For now, we are just porting the Authentication helper and controller. Additionally: - Session verification now also checks if the credentials in the config did not change. - Requests from loopback IP address now give full access to all operations, not just update. - IPv6 loopback address is recognized as well. - Requests forwarded by proxies are filtered out since local reverse proxies might come from loopback as well. One thing I do not like that any request with credentials will automatically persist the login to session but removing that feature can be done later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a from-scratch rewrite, moving a bit closer to Single Responsibility Principle.
We split handling of credentials-in-config and always-open authentication systems.
In the future, we will be able implement more methods this way.
This was motivated by session code being called in constructor,
which would break in CLI with Tracy strict mode.
For now, we are just porting the Authentication helper and controller.
Additionally:
One thing I do not like that any request with credentials will automatically
persist the login to session but removing that feature can be done later.