Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missized mobile navigation with fr translation #1065

Open
niol opened this issue Oct 23, 2018 · 3 comments
Open

missized mobile navigation with fr translation #1065

niol opened this issue Oct 23, 2018 · 3 comments

Comments

@niol
Copy link
Collaborator

niol commented Oct 23, 2018

9a358cd from #1054 made fr messages too long for the mobile nav menu. Either the messages should be made shorter (my preference) or the CSS fixed (not trivial). I can fix this but I'm not sure my preference is what people want.

odd_mobile_nav

@jtojnar
Copy link
Member

jtojnar commented Oct 23, 2018

I think I had a fixed CSS somewhere (maybe the vector icon branch).

@Binnette
Copy link
Contributor

Why don't we just hide button's text when area is too small ?
Also, current icons for "read/unread" are confusing. I never remember which one is read/unread 😢

Is it possible to change for something like this :
image

A dark envelope for unread messages, and a light openned one for read messages.

@jtojnar
Copy link
Member

jtojnar commented Oct 31, 2018

The issue with icon alone is that you do not know whether it indicates state or an action. It is ¿usually? expected that icons inside buttons describe the action, see for example play/pause buttons in a media player. Or for something closer, this is what GMail does:

image
image

It is consistent with “icons inside buttons denote action” rule, which is the exact opposite of your suggestion.

The text should be able to remove this ambiguity by using a verb, which should make it clear the button describes action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants