Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video player support for viewing response of video mimetype #17

Closed
ashitaprasad opened this issue May 5, 2023 · 9 comments · Fixed by #315
Closed

Add video player support for viewing response of video mimetype #17

ashitaprasad opened this issue May 5, 2023 · 9 comments · Fixed by #315
Labels
enhancement New feature or request good first issue Good for newcomers mimetype-previewer Response Previewer for different mime-types

Comments

@ashitaprasad
Copy link
Member

Use case

User should be able to directly play video in the response pane when the response is of content type video/H264, video/H265, video/mp4 etc. Full list of mimetypes available here. Currently, the app allows users to download the video response.

@ashitaprasad ashitaprasad added enhancement New feature or request good first issue Good for newcomers labels May 5, 2023
@Utkarsh4517
Copy link

I want to work on this can you please assign this to me @ashitaprasad

@Harsh1350
Copy link

I want to work for this issue Please assign this to me @ashitaprasad

@ashitaprasad
Copy link
Member Author

Hi @Utkarsh4517 @Harsh1350,
Firstly, Join our discord server so that you can message on the #foss channel whenever you encounter any issue. That is also our official channel where we have all discussions related to API Dash.
You must also follow the Contribution Guidelines.
We currently do not assign an issue to a single person, as it might not be the best approach.
Also, before sending a PR, just let me know when your code is ready for review.

@Nirsu
Copy link

Nirsu commented Dec 18, 2023

Hi !
I would like to work on this issue, I posted a message on discord :)

@animator
Copy link
Member

Sure @Nirsu
Please feel free to work on the issue and send across a PR.
If you have any query, kindly drop a message on the discord channel.

@ashitaprasad ashitaprasad added the mimetype-previewer Response Previewer for different mime-types label Feb 22, 2024
@mdrazak2001 mdrazak2001 mentioned this issue Mar 3, 2024
5 tasks
@monstajoe2002
Copy link

I saw that there's a closed PR for this issue. Can I still work on it?

@animator
Copy link
Member

@monstajoe2002 yes you can.

@monstajoe2002
Copy link

I created a PR here: #298

@animator
Copy link
Member

Related Flutter issue - flutter/flutter#53017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers mimetype-previewer Response Previewer for different mime-types
Projects
None yet
6 participants