Add the ability to hint the rolling_deploy with a named ELB #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've further extended my implementation as I found a wrinkle when we got to our production environment. Our dev and staging environments point to one instance, and the previous version of this PR worked fine for distinguishing between the two. However, in our production environment we run 3 ELBs - two for real production and one for a demo. We therefore want our deployments to production to affect 2 of the 3 ELBs. Bit annoying, but now this should suit that case as well. As before, my ruby is beginner at best, so please do recommend any improvements! |
edhgoose
changed the title
|
Hey there, thanks for your pull request, I'll try to get some time to review it as soon as I possibly can :) |
edhgoose
force-pushed
the
named_elb_deregister
branch
from
2f7d75e to
1d671a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #63, allowing you to specific the name of the ELB to de-register from.
It does have at least one limitation which is if multiple roles are specified which belong to different ELBs it'll only use the last one.
I also haven't written ruby before - so please feel free to change it up if anything looks rubbish!