Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding go modules support #35

Open
eliben opened this issue Jan 29, 2020 · 3 comments
Open

Adding go modules support #35

eliben opened this issue Jan 29, 2020 · 3 comments

Comments

@eliben
Copy link

eliben commented Jan 29, 2020

Please consider adding Go modules support by running "go mod init github.com/fortytw2/leaktest" and committing the resulting go.mod file.

@fortytw2
Copy link
Owner

@eliben leaktest should support go modules anyways, I'm pretty sure.

@eliben
Copy link
Author

eliben commented Jan 29, 2020

As a user of leaktest, it worked fine within a module environment - as you have properly tagged semver releases. Thanks!

It may still be a good idea to add a trivial go.mod going forward, however. See https://github.com/golang/go/wiki/Modules#should-i-still-add-a-gomod-file-if-i-do-not-have-any-dependencies for more details.

@fortytw2
Copy link
Owner

Great! Thanks for the link too, I'll keep this open and come back to it eventually :) Since leaktest has no external dependencies and likely will continue working for a long time without a go.mod, I'd rather like to avoid adding files of dubious benefit to the repo / anyone, really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants