Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: Remove tabs from code base #350

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Mar 18, 2021

Found some occurrences of tabs, which are banned from this code base in the style guide.

Copy link
Member

@ivan-pi ivan-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any GitHub action running the code through a linter do we?
Hopefully the GSoC Fortran parser project moves us in this direction.

I know there is linter under active development at CERFACS: https://pypi.org/project/flinter/

@awvwgk
Copy link
Member Author

awvwgk commented Mar 18, 2021

There is the “PR-Review / review-dog / misspell” action, which I have seen in action only once flagging a false positive. No linting or formatter action so far. Is #3 the right place to discuss this or should we open a new issue on this?

@ivan-pi
Copy link
Member

ivan-pi commented Mar 18, 2021

I would prefer to keep such technical "details" out of #3.

Your post over at fortran-lang/fpm#197 summarizes the currently available auto-formatting tools pretty well. Maybe it is easier to first decide to adopt some CI there it can be ported to stdlib later.

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a no-brainer. Thanks!

@milancurcic milancurcic merged commit 6050923 into fortran-lang:master Mar 19, 2021
@awvwgk awvwgk deleted the whitespace branch March 19, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants