Bitsets #236
Closed
Bitsets #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New documentation for the proposed stdlib_logger.f90 module. The documentation differs in style from that of the other modules in the following ways: 1. I thought it benefitted from an introduction giving an overview of the module 2. It has a section describing the constants used as error codes with a table summarizing the constants. The other modules do not appear to have significant public constants 3. It has a section summarizing the derived type. The other modules do not define a public derived type. 4. It has a section describing the `global_logger` variable. The other modules do not define a public variable. 5. It has a table summarizing the various procedures/methods in one place. I think using the module benefits from this summary 6. With the extra material the procedure/method description are one heading higher than in the other documentation. I don't think this is noticeable. 7. The "syntax" has the self argument at an awkward position. The other modules don't have the equivalent of the self argument, and I couldn't see another place to logically put it. 8. The "syntax" follows the standard in using a single pair of square brackets to delimit a run of optional arguments, rather than the other document's use of a pair of square brackets for each optional argument. This is easily changed. 9. The document follows the standard in identifying the class of each procedure. 10. I follow the standard in describing the intent of each argument. The other documentation omits that. This is easily changed. 11. I am wordier than the other documenters. This is hard to change. 12. I ended up upper casing only specifiers that are character strings. I can lower case those, upper case other specifiers or Fortran keywords easily. I just need specific guidance on how to upper/lower case.
The source code for the stdlib_logger.f90 module. It defines one derived type, several constants and procedures/methods to implement loggers, and one variable intended to serve as a global logger.
The test code is quite a bit of a mess. The procedures add_log_file, add_log_unit, and remove_log_unit have failure modes that are modified with a `stat` argument, and need to be tested to be sure the codes do not wrongly add/remove a unit when the stat argument is not success, and ensure that the stat stat argument returns the correct error code. Any suggestions you have to improve it would be appreciated.
These won't overwrite existing files
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Made the error code name consistent with that used for my bitsets and error_codes modules, where for ease of lookup I put what is invalid before the invalid.
to compile main bitsets files
to compile the main bitsets files
To compile the bitsets test codes
added makefile.manual to compile the two test codes and the test codes test_stdlib_bitset_64.f90 and test_stdlib_bitset_large.f90.
to add bitsets subdirectory.
to add bitsets subdirectory
Added dependencies of stdlib_bitset_64.o and stdlib_bitset_large.o on stdlib_bitsets.o.
Removed the pure attribute from subroutines that invoked error stop.
Removed the pure attribute from subroutines that invoked error stop.
For bitset_64 changed integer(block_kind), private, allocatable :: block to integer(block_kind), private :: block = 0
|
@wclodius2 A solution to do that is to:
EDIT: I copied your branch in my repo, and all actions passed! |
|
@jvdp1 How do I sync a branch with the master? I am not seeing any obvious way to do this on https://github.com/wclodius2/stdlib/tree/bitsets2/src. |
|
In your case I would recommend the following: This makes sure you're master branch is up to date with the fortran-lang master branch, and then does a merge commit, bringing any recent changes into your branch. Let me know if you need any additional details. |
|
I have created a PR for a branch called bitsets3. The PR had one one that failed on ubuntu, out of six attempts, three on ubuntu and three on macOS.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is intended to provide implementations of bitsets. It defines a parent abstract type
bitset_type, and two descendants:bitset_64for bitsets up to 64 bits in size; andbitset_large, for larger bitsets. The main code is implemented in the module filesrc/stdlib_bitsets.f90and its submodule filessrc/stdlib_bitset_64.f90andsrc/stdlib_bitset_large.f90. There are also the test codessrc/tests/bistsets/test_stdlib_bitset_64.f90andsrc/tests/bistsets/test_stdlib_bitset_large.f90and a markdown documentdoc/specs/stdlib_bitsets.md. Various otherCMakeLists.txtandMakefile.manualfiles have been modified so that the code should be compilable withcmake ./ormake -f Makefile.manual.